-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flit-core is installed alongside with tests #403
Comments
I'm interested you say packages tend not to do this, because I thought that a lot of packages do - e.g. numpy, matplotlib, Jupyter packages all include their tests in the package that gets installed. Maybe it's more common in the scientific Python world than beyond that. There's no particular reason flit & flit-core differ; I go back & forth on which way I prefer, and flit has caught both sides of that. |
I checked ~10 most popular packages from PyPI stats where none of them gets installed with tests. Those you mention, however are. |
I've seen some packages where the tests were just wired badly, and didn't run at all except as part of the installed wheel. But yeah, generally the point of tests is to run them as part of the process of making final distribution artifacts. Sadly there's no way for pip to automatically do this for you, but meta-package managers generally do. Anyway... looks like the wheel file would drop from 48K to 24K if the tests are removed (324K to 92K for the extracted directory), so halving the network usage seems useful. At any rate, this doesn't exactly provide a test entry point, so users wanting to test this would probably have to do something like:
Which seems a bit convoluted and, unlike https://github.com/takluyver/flit/blob/b944ecceabe6c01f45d80c3c4c9160f97829e4c3/tox.ini#L14-L34 from the root of the git repo or sdist, is very much not documented. |
Tests no longer seem to be installed in 3.10.1 (it was still installed in 3.9) - came across that when updating the Fedora package (and the test deletion failed). Can this be closed? |
Yup, I changed this in #691. |
Hello,
When tackling the update of flit in Fedora I came across a difference in installation of
flit
andflit-core
- the latter is installed withtests/
. I wonder if this is by design, as usually packages tend not to bring tests (as in this case,flit
).Would you consider a change in installation process for
flit-core
?The text was updated successfully, but these errors were encountered: