Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email attributed to wrong project author #14813

Open
SnoopJ opened this issue Oct 27, 2023 · 3 comments
Open

Email attributed to wrong project author #14813

SnoopJ opened this issue Oct 27, 2023 · 3 comments
Labels
blocked Issues we can't or shouldn't get to yet bug 🐛

Comments

@SnoopJ
Copy link

SnoopJ commented Oct 27, 2023

Describe the bug

If a project defines multiple authors, and the first author does not list an email, PyPI will erroneously attribute the first email address in the metadata to that first author.

Expected behavior

PyPI should not attribute any email to the first author if one is not given.

To Reproduce

See an example here: https://pypi.org/project/sopel-iplookup/1.0.0/

The project's authorship metadata looks like:

[project]
authors = [                                                                                                                                                           
  { name="Dimitri Molenaars" },                                                                                                                                       
  { name="Elad Alfassa", email="[email protected]" },
  ...
]
...

Where there is no email listed for Dimitri Molenaars. On the PyPI project page linked above, however, the address [email protected] is attributed to this author.

The generated METADATA splits this information across the Author and Author-email fields, which may be related to the bug.

My Platform

N/A

Additional context

The closest open issue I can find is #9400, but that seems distinct.

@SnoopJ SnoopJ added bug 🐛 requires triaging maintainers need to do initial inspection of issue labels Oct 27, 2023
@aaraney
Copy link

aaraney commented Oct 29, 2023

The order of the authors field could be taken to have meaning (i.e. 1st author, 2nd author, etc.) or it could just be an unordered list of authors. I think you could argue either way. I personally lean towards it being an unordered collection as there is no discriminator to denote authorship ordering.

@dgw
Copy link

dgw commented Oct 30, 2023

Regardless of ordering, surely it is a bug to display one author's name with a different author's email address on the package index? And especially if the author list is considered unordered, displaying the email address of the first author in Author-Email with the name of the first author listed in Author makes even less sense.

This behavior is described exactly by a comment on #9400, in fact: One author without an email address associated is displayed as the name on PyPI, with the email address of another entry.

dgw added a commit to sopel-irc/sopel that referenced this issue May 27, 2024
Since pypi/warehouse#9400 and pypi/warehouse#14813 (perhaps others too)
remain unresolved, let's keep our metadata simple. Incomplete metadata—
i.e. the email addresses this commit removes—is the only thing worse
than straight-up *incorrect* metadata. We don't want any author or
maintainer names to be attached to the wrong email addresses on the
published package page.
lgarrison added a commit to flatironinstitute/nifty-ls that referenced this issue Jun 12, 2024
@miketheman miketheman added blocked Issues we can't or shouldn't get to yet and removed requires triaging maintainers need to do initial inspection of issue labels Oct 11, 2024
@miketheman
Copy link
Member

Marking as blocked for same issue as noted in #16496 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues we can't or shouldn't get to yet bug 🐛
Projects
None yet
Development

No branches or pull requests

4 participants