-
I was just checking a bit the osm code. It seems to me that we have some code duplications. A. See build osm: B. And clean osm: C. This function is also not used at any place: Can we remove C and merge A & B? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment
-
@pz-max, thank you for rising this question! My feeling is that it would be a very good idea to merge two versions of As for |
Beta Was this translation helpful? Give feedback.
@pz-max, thank you for rising this question!
My feeling is that it would be a very good idea to merge two versions of
add_line_endings_tosubstations( )
. Actually, when modifying them I was considering to move them intohelpers
script but was concerned if an application area of the function is not too narrow for the helpers.As for
create_bus_df_from_lines( )
, was it probably an initial version ofadd_line_endings_tosubstations
? :) If that's the case andcreate_bus_df_from_lines( )
is not needed anymore, could we probably remove it and use its name foradd_line_endings_tosubstations( )
? Because the main effect of theadd_line_endings_tosubstations( )
is exactly creation the buses from the …