Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure coverage with tests of all workflow configurations #1016

Open
ekatef opened this issue Apr 30, 2024 · 4 comments
Open

Ensure coverage with tests of all workflow configurations #1016

ekatef opened this issue Apr 30, 2024 · 4 comments

Comments

@ekatef
Copy link
Member

ekatef commented Apr 30, 2024

It appears that some configuration of the workflow are not captured by CI.

For example, recent bugs in augmented_line_connections have been obvious with run_tests but were not found by CI, as reported by @finozzifa when working on #1011 and #1013.

Currently augmentation is not used in the tutorial:

augmented_line_connection:
add_to_snakefile: false # If True, includes this rule to the workflow

But it's switched-on in custom.config which should be used to build a test configuration:

augmented_line_connection:
add_to_snakefile: true # If True, includes this rule to the workflow

Describe the feature you'd like to see

Would be great to ensure that CI runs all the rules.

@ekatef
Copy link
Member Author

ekatef commented Apr 30, 2024

As a comment, it would be also great to use both AC and DC representations in CI tests. Although, DC part is a bit tricky as it requires adding new data to the tutorial.

@ekatef ekatef mentioned this issue Apr 30, 2024
8 tasks
@ekatef
Copy link
Member Author

ekatef commented Apr 30, 2024

We still have a number of testing related issues which may be related to this one. In particular,
#625 and #715 can be relevant.

@ekatef
Copy link
Member Author

ekatef commented Dec 14, 2024

Is linked with #1174

@davide-f
Copy link
Member

Also linked to #1203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants