Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule build_shapes #1130

Open
milyas009 opened this issue Oct 5, 2024 · 1 comment
Open

rule build_shapes #1130

milyas009 opened this issue Oct 5, 2024 · 1 comment
Labels
feature request Ask for new features good first issue Good for newcomers

Comments

@milyas009
Copy link
Contributor

In PyPSA-earth while executing the "Rule build_shapes" for any other countries, the output still contain "resources/shapes/africa_shape.geojson". May be just a naming mistake?

output: resources/shapes/country_shapes.geojson, resources/shapes/offshore_shapes.geojson, **resources/shapes/africa_shape.geojson**, resources/shapes/gadm_shapes.geojson
    log: logs/build_shapes.log
@davide-f
Copy link
Member

davide-f commented Oct 6, 2024

Thanks @milyas009 :D
The content of africa_shape.geojson always depends on the countries selected in the workflow.
For example, if you choose TH, then the content will be TH.
We agree that the choice of the name "africa_shape" is misleading and indeed it would be great to have a PR that proposes a revision of its naming to something like "region_shape" or alike that is country/continent neutral.
Proposals are welcome :)

The expected changes related to the file "Snakefile" in particular, changing all references to "africa_shape" in the snakefile, such as:

africa_shape="resources/" + RDIR + "shapes/africa_shape.geojson",

Would you like to try? :)

@davide-f davide-f added good first issue Good for newcomers feature request Ask for new features labels Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Ask for new features good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants