Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run multiple MCMC chains with NumPyro without flags #17

Open
null-a opened this issue Oct 1, 2019 · 3 comments
Open

Run multiple MCMC chains with NumPyro without flags #17

null-a opened this issue Oct 1, 2019 · 3 comments

Comments

@null-a
Copy link
Collaborator

null-a commented Oct 1, 2019

See pyro-ppl/numpyro#364.

@fehiepsi
Copy link
Member

fehiepsi commented Oct 29, 2019

@neerajprad Should we set num_host_device_count to 4 by default? If users run MCMC with a higher num_chains, then we still have a warning message which says that parallel will fall back to sequential and points to the right place numpyro.set_host_device_count for users. At least I have no knowledge about the side effects of having a higher default device count than 1, and having num_host_device_count=4 seems to work even for 1 CPU system (we can test this in Travis).

@neerajprad
Copy link
Member

@fehiepsi - Do you mean setting it to 4 in brmp or in NumPyro? I think setting it to 4 for brmp makes sense (for CPU). In any case, I think we should also try to develop a better understanding of XLA's behavior when we change this environment flag. Even if it seems safe now, it is possible that XLA starts using this flag for some optimization in the future and users will be pushed into a regime of poor performance simply because the default value for the environment flag is different than the actual device count or how XLA expects this flag to be used.

@fehiepsi
Copy link
Member

I meant in both libraries. :D

we should also try to develop a better understanding of XLA's behavior when we change this environment flag

Agreed! We should talk about this when we meet its developers. For now, let's keep the default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants