Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the Patsy library #19

Open
null-a opened this issue Oct 1, 2019 · 0 comments
Open

Make use of the Patsy library #19

null-a opened this issue Oct 1, 2019 · 0 comments

Comments

@null-a
Copy link
Collaborator

null-a commented Oct 1, 2019

I made a great deal of use of the (very nice) documentation for Patsy while implementing brmp. As a result the two libraries have a lot of functionality in common. (Particularly around interpreting formulae and coding design matrices.) We ought to think about whether we can avoid this duplication of effort eventually.

As far as I know, the main reason we couldn't immediately switch to depending on Patsy is that it doesn't support mixed effects formulas (pydata/patsy#130). The bambi library side steps this by having the user give separate formulae for the fixed and random effects.

It's worth keeping in mind the fact that brms includes a few extensions to the lme4 syntax to support some of its more advanced features. If we choose to do something similar I guess we'd find ourselves extending the formula language beyond what is currently supported by brmp or Patsy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant