Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of marginals when we have too few samples/chains to compute diagnostics #28

Open
null-a opened this issue Oct 9, 2019 · 0 comments

Comments

@null-a
Copy link
Collaborator

null-a commented Oct 9, 2019

Once #25 is merged marginals will include n_eff and r_hat columns. In some (not very common) situations we don't have enough chains and/or samples to compute these, in which case we show nan in the table. I'm not sure this is very informative, so perhaps it would be better to show something like n/a instead.

This isn't a trivial change because the current assumption is that the table holds only floats and so is backed by a numpy array. Perhaps this could to be switched to a pandas data frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant