Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offset function in the formula #82

Open
Henrilin28 opened this issue Oct 16, 2020 · 5 comments
Open

offset function in the formula #82

Henrilin28 opened this issue Oct 16, 2020 · 5 comments

Comments

@Henrilin28
Copy link

I am wondering if the team has plan to develop offset function? What is the expecting timeline for this?

@eb8680
Copy link
Member

eb8680 commented Oct 17, 2020

We don't have any plans for this, but open source contributions are welcome!

@matteby
Copy link
Contributor

matteby commented Nov 23, 2020

I'd be interested in support for this as well. I may take a look at implementing it if I can find the time in the next few weeks.

@null-a
Copy link
Collaborator

null-a commented Nov 24, 2020

I wrote a lot of the code in this repository. I'm no longer actively working on this, but I'm still following the issues. Feel free to ask me about anything I've done that doesn't make sense. Good luck!

@matteby
Copy link
Contributor

matteby commented Nov 24, 2020

@null-a Thanks!

I haven't yet had time to think through how to implement w.r.t. this code base. If there has been any thoughts or discussions on how to support I'd be interested to hear. Otherwise, I'll be sure to ask if I run into any questions.

@null-a
Copy link
Collaborator

null-a commented Nov 24, 2020

I'm not aware of any previous discussion. (And don't even recall what offset does off the top of my head!) Nevertheless, I'd be happy to discuss a general strategy at some point if that would be helpful.

As a starting point, here's a rough high-level sketch of how we go from the inputs of formula, dataset and description of custom priors we get from the user, to either Pyro/NumPyro code.

                DataFrame metadata --|
                                     |-> `ModelDescPre` --|
input string --parser--> `Formula` --|                    |-> `ModelDesc` --code gen--> code
                                                 priors --|

(The items in back-ticks denote Python classes.)

My guess would be that each stage of this pipeline would need to be updated to handle offsets. i.e. Update the parser to parse out offsets and represent them in Formula, update ModelDesc (which is something like an abstract description of the model) to also represent offsets, and update the code generators to output code that implements the appropriate functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants