Tweak automated registration for distribution-to-funsor conversion #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #386. Motivated by @ordabayevy's forum post about generating Funsor wrappers for custom distributions.
Currently, generic
TorchDistribution
-to-funsor.distribution.Distribution
conversion is handled by a single pattern:This design requires the pattern to somehow identify a Funsor counterpart
funsor_dist_class
tobackend_dist
, which it currently does somewhat hackily by looking in the global namespace. This PR tweaks this logic so that no lookup is necessary:By including the final line above in the distribution wrapper generator
funsor.distribution.make_dist
, users should in many cases no longer need to implementto_funsor
for custom distributions.I have also deleted a superfluous conversion pattern
funsor.distribution.mvndist_to_funsor
whose functionality is duplicated in aneager
pattern.Tested: