Replies: 1 comment
-
Hi there, thanks for opening the discussion. I agree with you suggestion : we should send a notification when a new sequence is created ! I think, we do not need so far to send notification again if the are new detection in a sequence ! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
As mentioned in #412, we might have a bad pattern for Telegram notifications
Currently we send this when a detection is created (cf. https://github.com/pyronear/pyro-api/blob/main/src/app/api/api_v1/endpoints/detections.py#L136)
I suggest we update this to only send one if a sequence is created (https://github.com/pyronear/pyro-api/blob/main/src/app/api/api_v1/endpoints/detections.py#L117). And the question now is whether we should send a notification when a new detection is addded to an existing sequence.
What do you think?
Beta Was this translation helpful? Give feedback.
All reactions