Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[installations] add boolean field to set the relevance of a device #123

Closed
fe51 opened this issue Mar 18, 2021 · 0 comments · Fixed by #127
Closed

[installations] add boolean field to set the relevance of a device #123

fe51 opened this issue Mar 18, 2021 · 0 comments · Fixed by #127
Assignees
@frgfm
Labels
endpoint: installations high priority question Further information is requested
Milestone
0.1.2

Comments

@fe51
Copy link
Member

fe51 commented Mar 18, 2021

Feature

Add boolean field "is_relevant" to installation table.

Motivation

In the case of a device that points a no_alert site it is needed to flag it with is_relevant as false in order to not consider alerts coming from this device.

Question

If the related PR pass after alembic migration (#112), this feature need to be implemented as an alembic migration isn't ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frgfm frgfm

Labels
endpoint: installations high priority question Further information is requested
Projects
None yet
Milestone
0.1.2
Development

Successfully merging a pull request may close this issue.

feat: Added is_trustworthy boolean field to installation table pyronear/pyro-api
2 participants
@frgfm @fe51