-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Tk support #1298
Open
Daetalus
wants to merge
4,666
commits into
pyston:master
Choose a base branch
from
Daetalus:tk_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Tk support #1298
Changes from 250 commits
Commits
Show all changes
4666 commits
Select commit
Hold shift + click to select a range
bf8aafd
Merge commit '3ec9cf9' into merge_missing2
undingen f742d0c
Merge commit 'ff03e99' into merge_missing2
undingen 3164dc3
Merge commit 'c5858c7' into merge_missing2
undingen 64bc976
add __name__ attr to method-wrapper
da8686b
Merge pull request #1182 from kmod/check_refcounting
kmod 1d1236b
Merge pull request #1170 from Daetalus/numpy_update
undingen 96bcd8c
Support CAPI exceptions through this function
kmod 413d022
Some numpy_test.py improvements
kmod 307c2a0
Switch to smallvectors here
kmod 4f83635
Extract the logic from DEFAULT_CLASS_SIMPLE
kmod 49f8df1
Merge pull request #1183 from undingen/merge_missing2
kmod 9c925c4
Merge pull request #1186 from kmod/numpy_perf
kmod a7653f0
Merge pull request #1187 from kmod/perf9
kmod 7e53e4e
Reenable the 'extra' tests
kmod 2023279
Don't create .pyc files for the main script
kmod cfae319
Oh it wasn't an issue, we were just passing more tests than expected
kmod 8807084
Merge pull request #1189 from kmod/extra_tests
kmod 24ee166
store and restore is_reraise flag
undingen 1257cf6
enable sqlalchemy_smalltest
undingen c429f19
Merge pull request #1185 from undingen/sqlalchemy_ref
undingen 1cfb7ac
Cleanup
kmod b5d22ec
Turn these optimizations back on
kmod 24f4462
Merge pull request #1192 from kmod/refcounting_merge
kmod 33e1db9
tuple: implement tp_as_sequence->sq_contains
undingen 5816b3d
binop: use PyNumber_* for user defined classes
undingen b22043a
binopInternal: make inplace a template argument
undingen 21ab994
Merge pull request #1198 from undingen/tuple_contains
undingen 938b019
microptimization: mark _PyGC_generation0 as having a const address
undingen e335b4c
Merge pull request #1188 from dropbox/refcounting
kmod 12e93c0
Force-rebuild during a pgo build
kmod 2c916cb
Add numpy_fulltest.py that runs the full numpy testsuite
kmod e44c12e
Make bind_obj_out borrowed
kmod 026b316
rearrangeArgs: don't own refs for positional_to_positional
kmod 0d111f8
Loosen these checks if we imported a third party c extension
kmod 9ffdead
Merge pull request #1202 from undingen/const_generation0
undingen 62ee763
Merge pull request #1203 from undingen/use_pynumber
undingen 9d5e5b2
there's no rewriter support in hex and oct in Pyston for now, so just…
a32afb2
Merge pull request #1201 from Daetalus/nexedi_numpy_fixing
undingen f9fcd85
Merge pull request #1200 from kmod/extra_refs
kmod 2876c09
Update test results
kmod 14ea4c0
Merge pull request #1206 from kmod/numpy_updatetest
kmod ea4cd6e
BoxIteratorGeneric: call PyIter_Next() lazily
undingen a31e032
revert some pyston changes now that we have ob_refcnt
undingen 22b0776
update virtualenv to the one which always sets zip_safe=False
undingen 1e54256
Merge pull request #1208 from undingen/zip_safe
undingen a6fca70
Merge pull request #1205 from undingen/BoxIteratorGeneric_fix
undingen 19bf066
str: use tp_as_sequence instead of tp_as_number
undingen 87f8c6a
Merge pull request #1210 from undingen/str_tp_as_number
kmod 5e1a850
PyObject_New: register the type if the type is not yet registered
undingen b2a94fc
travis-ci: add some numpy requirements
undingen bf20355
Create a simple Dockerfile
kmod 61ac7b5
Merge pull request #1207 from undingen/register_types
kmod d793a3a
Workaround for the "terminator in middle of basic block" issue
kmod a994ec0
Fix a rewriter bug
kmod 8e8c9a8
Copy in CPython's descrobject.c
kmod 4c3c693
Switch to using CPython's getset, member, wrapperdescr, and wrapper t…
kmod 75d0050
Reenable our tpp_call rewriting for these types
kmod 2f2c2f2
Support Rewriter::addGCReference, now without leaks
kmod 0751c27
Use CPython's PyMethodDescr_Type
kmod 7f84725
Reenable rewriting for method-descriptors
kmod c9cab0e
Merge pull request #1211 from kmod/docker2
kmod 04f4515
Get rid of the numpy patch
kmod 6dd62f7
cffi failures scare me
kmod a11ffa7
Manually specify the output of methoddescr.py
kmod 7974eb8
Merge pull request #1209 from kmod/cpython_descr2
kmod 499c4c0
Some packaging / distributing updates
kmod f4f3d39
exec, input: if globals has no __builtins__ add it as a dictwrapper
undingen 865f7ba
Add a pyston/pyston-numpy docker image as well
kmod f788cfa
Merge pull request #1212 from kmod/packaging
kmod c4384c6
update list of failing cpython tests
undingen 970ed60
Bump version numbers
kmod c6d8021
Merge pull request #1226 from kmod/packaging
kmod 08d75e5
Merge pull request #1223 from undingen/cpython_tests2
kmod e37660e
Merge pull request #1221 from undingen/exec_builtins
kmod d1b799e
Temporarily disable the clang build on travis-CI
kmod ecb7025
Fix gcc debug-mode issue
kmod 5380b5c
Fix std::move error on temporary object
c-rhodes b1137c1
Merge pull request #1237 from c-rhodes/fix_builtins_std_move
undingen 251f48a
Bump build time to 60 minutes
kmod 5ae5bf2
Merge pull request #1235 from kmod/disable_clang_build
kmod ec0924c
Fix set.py on new platforms
kmod d96795b
Copy this CPython test change
kmod ce69b81
bjit: change PP sizes and some misc minor improvements
undingen 031526a
bjit: let OSR handle multiple loops
undingen 4253de6
bjit: directly emit 'is' and 'is not' comparisons
undingen dc85d00
bjit: make nonzeroHelper return a borrowed reference
undingen a9a9c6c
bjit: use r12 and r15
undingen b022674
bjit: reenable local block var optimization
undingen 75b794a
bjit: allocate code block using mmap
undingen ce2d965
rewriter: cleanup call() using a template and add a can_throw argumen…
undingen 229fb46
rewriter: directly embed additional ref uses and bump uses early when…
undingen 9fd4924
bjit: enable MAP_32BIT
undingen ccdbbaa
float.cpp: now that we have float.c use some of the functions directly
undingen 11c0b2c
use std::isinf and std::isnan
undingen dc2f38c
Don't include definedness analysis in phianalysis time
kmod 71ece5c
Extend time limit for force_llvm tests
kmod 4ddb6e4
Copy CPython PyInt_AsLong implementation with some Pyston modifications
6c6e888
Add PYSTON_CONST macro
dc0c342
loose the type check in complexDivFloat
2c79c3f
Initialize the base class in PyType_Ready if it not get initialzied.
820dd0c
Merge pull request #1236 from undingen/cleanup_float_cpp
undingen e717448
Merge pull request #1227 from undingen/bjit_opt2
undingen 3407b2d
Merge pull request #1229 from Daetalus/scipy_fixing_1_nexedi
undingen 74311c5
Bump integration test timeout as well
kmod 5346677
Merge pull request #1234 from kmod/vregs_everywhere_merge
kmod f142484
vregs: split them in three parts and reuse them in some cases
undingen 74ee55c
Merge pull request #1239 from undingen/bjit_opt2_with_vreg_reuse
kmod 24a5b0c
Improve REPL support
c-rhodes 4f48bbe
make more list unit test pass
aisk eb8815b
Merge pull request #1245 from c-rhodes/1097
undingen b21fad5
Merge pull request #1246 from aisk/test_list
undingen a60e8c8
Add pyston_ prefix to Pyston defined True and False.
78e068b
revert Pyston's change about PyBoolObject
911ea3a
copy pyport.h from CPython, and add some pyston changes.
01b0367
download cython from github instead of cython.org
undingen f773465
Merge pull request #1248 from undingen/cython_url
undingen af389a7
Merge pull request #1231 from Daetalus/scipy_fixing_2_nexedi
undingen ca2ff3c
Remove redefinition error in pyport.h
undingen a5488ae
Merge pull request #1250 from undingen/pyport_fix
undingen 4989639
Add new PyCode_HasFreeVars implementation
5f37b16
perf: add a script which allows 'perf report' to disassemble JITed fu…
undingen 31a515b
Merge pull request #1244 from undingen/bjit_profiling
undingen 120eb24
copy CPython's slot_tp_call implementation to Pyston
03a8895
Time the build part of the CI script
kmod cbed427
Smart leak checker
kmod 0460ca6
Interpreter: refcount safety for signals
kmod 43351fb
llvm JIT: refcount safety for signals
kmod 5466b67
Add a simple test for these issues
kmod 616dd7b
Merge pull request #1252 from kmod/telnetlib
kmod d43ea30
Dict ctor should not propagate certain exceptions
kmod 33ac174
Support staticmethod.__func__
kmod ae2b1c0
Regression test: this test throws an irgen assertion
kmod a3e4178
Turn down verbosity
kmod 8bc8f87
Improve lineno handling
kmod 5edb898
Merge pull request #1253 from kmod/linenumbers
kmod 5cc0a09
Add api_test extension for test C API, initially add PySet_Size test.
3eb3e5f
Add SciPy test, but not enabled yet.
9742646
rewriter: improve decref and xdecref
undingen 2023c92
rewriter: remove duplicate getAttr calls
undingen 805b30c
bjit: keep track which vregs are known to be non null
undingen 72fb068
rewriter: add helper which makes it easier to select the best 'call' …
undingen 33baefb
rewriter: better scratch handling
undingen a93836f
bjit+rewriter: use const_loader.loadConstIntoReg more often
undingen 4dd4b5b
Merge pull request #1255 from undingen/bjit_opt7
undingen cc87a03
Merge pull request #1251 from Daetalus/new_api_nexedi
kmod e6931d6
Enable CPython's macro PyCFunction_GET_FUNCTION. Fixes issue #1260
5b89e0e
Enable function.func_closure and function.__new__
kmod 7ea089b
Revert "Temporarily disable the clang build on travis-CI"
undingen a6b4559
Merge pull request #1266 from undingen/reenable_llvm_build
undingen 76b2870
If type->tp_getattr is not NULL, don't set has_getattribute to False
255e787
Merge pull request #1265 from kmod/copyfunc
kmod 73eb4a8
Merge pull request #1267 from Daetalus/scipy_fixing_3_nexedi
undingen d42e89a
Add type.__basicsize__, type.__itemsize__
258a2b0
ICs: variable size IC slots
undingen 01c34d8
Dictionary comparisons #1135
3d34fe7
Fix 3-way-compare behavior on our old compareInternal() path
kmod 818927c
bjit: fix failed OSR
undingen 7f3083e
Merge pull request #1274 from undingen/bjit_osr_failure
undingen f2bf812
Merge pull request #1272 from kmod/sizeoftank_dictcomparisons
kmod dc0a2f2
Merge pull request #1276 from sizeoftank/work_for_issue1216
undingen 5f562c4
Merge pull request #1259 from undingen/rewriter_slots4
undingen 5271adc
Optimize BB traversals by mapping to ints
kmod 62b5c6b
Some small micro-optimizations
kmod 57ba9ca
large_import_bench.py
kmod bfe0638
Remove the "CPython executable parser"
a5dc1b1
Merge pull request #1268 from Daetalus/cpython_exe_parser
undingen 20c9a7d
Merge pull request #1278 from kmod/refcounter_opt
kmod b0dccfb
Stop to emit code if rewrite failed(failed == true)
7f56274
rearrangeArguments added a extra ref in numpy resize function
a0affc4
Merge pull request #1270 from Daetalus/scipy_fixing4_nexedi
undingen f5a40a2
deinitFrame: don't modify CAPI exception state
undingen 20cb1cc
Merge pull request #1281 from undingen/deinitFrame_exc
undingen 2edfc49
fix crash in setitem rewrite path
undingen 58c1fdd
capi: add the direct access macros back
undingen 0ebe7b6
Merge pull request #1283 from undingen/use_cpython_macros
undingen 7af2906
Track down an elusive reference leak
kmod 44ccbe1
Merge pull request #1284 from kmod/telnetlib
undingen 3fe4964
Explicitly represent undefinedness in DefinednessAnalysis
kmod 742dc66
Make DefinednessAnalysis return a bitset
kmod b192765
DefinednessAnalysis uses vectors internally now
kmod 84b05da
Change varargs and kwargs to AST_Names
kmod 9f17a19
Switch PhiAnalysis to use VRegSets
kmod d686cbf
Switch LivenessAnalysis to vregs
kmod 19e073e
ScopingAnalysis fix for lambdas
kmod 18c6b30
Convert type_analysis to vregs
kmod 8052061
Change analysis APIs to take vregs
kmod 061e994
Move closure/generators out of the irgen symbol table
kmod 0999d34
Move is_defined names out of the symbol table
kmod 31f263f
Convert OSR to use vregs
kmod 0870415
Only allow getName for vregs that we will give names
kmod b29380d
Switch frame introspection to use vregs
kmod 6b4e418
Turn vreg-reuse back on
kmod 279edc7
Update section_ordering
kmod cdaed13
Update unittests
kmod 43992f5
This include isn't needed anymore
kmod b2f6149
Incorporate Marius's feedback
kmod a0529f4
Cleanup: iterating a VRegMap skips default entries
kmod 5500b77
Fix some vreg-reuse confusion
kmod 44cdb66
Cleanup
kmod e4938dd
only lookup __[set/get/del]slice__ for slice AST nodes
undingen a044540
Disable flaky pyopenssl test
kmod 1923d11
Merge pull request #1277 from kmod/vregs_everywhere
kmod 4d4d78a
Merge pull request #1280 from undingen/slice_lookup
undingen 34d5d93
Add list tp_as_mapping for issue #1197
6a6d74f
add tp_as_mapping slots for str & tuple.
9ac97a1
Support attrwrapper as globals argument to execfile
kmod 10f9ec7
Make pyc_stress_test shorter
kmod 37fa8a9
Merge pull request #1289 from kmod/execfile_globals
kmod ef00782
Merge pull request #1287 from sizeoftank/work_tp_as_mapping_issue1197
kmod 2208749
VRegSet: use a llvm bitvector as representation
undingen 7044c24
Merge pull request #1291 from undingen/bitvector
kmod 62ac9c8
Don't require annotating explicit null pointers
kmod b00a768
Fix unexpected-AttributeError-when-importing
kmod 229ef9b
Fix disabling of pyopenssl test
kmod f075558
Merge pull request #1292 from kmod/scipy
kmod 87edc34
str does not have an __iter__
kmod f0a2338
Optimize seq_iter protocol
kmod c7640dc
loose the dummy code object check
2190118
Add argument check for PyDict_Next
dfd5366
Make unboxed seqiter functions available
kmod a597d1b
Update Cython from 0.22 to 0.24
8818130
Rename numpy_test to scipy_test and add scipy test suite.
9b6e419
When build scipy, do not enable implicit-function-declaration
3489a0a
Merge pull request #1286 from Daetalus/scipy_fixing5_nexedi
undingen 50552a0
assembler: fix cmp encoding
undingen 3959924
assembler: fix movsd(Indirect src, XMMRegister dest) encoding
undingen dc1e134
assembler: (%rbp) must be encoded as 0(%rbp)
undingen 6a90c79
bjit: better hasnext handling
undingen a0b7020
unwinding: libunwind expects dwarf reg numbers
undingen f0e39c1
bjit: use a bitset for register tracking in the rewriter and use r12,…
undingen 5c0d56b
bjit: args in the entry block are non null + pass info on to successo…
undingen 2e78077
Merge pull request #1290 from undingen/bjit_opt8
undingen 14ab985
Turn off flaky formencode test
kmod 57acfd0
One more test is passing here
kmod d375dfd
Merge pull request #1293 from kmod/str_iter
kmod b9ab979
docker: we are now using cython 0.24 + update readme for 0.5.1 release
undingen abb4b13
Merge pull request #1295 from undingen/release051
undingen fc7e22e
Bump version numbers
undingen ea8cd1d
Merge pull request #1296 from undingen/bump_06
undingen 536fd62
Add missing build_docker.sh
kmod b4b69eb
fix duplicate docker builds
kmod ae07536
forgot to update this version number
undingen 0c37fa0
Add sq_slots & mp_slots to instance (issue #1197)
3dc94a1
str: use cpythons [r]partition
undingen f71d5b3
Merge pull request #1299 from undingen/fix_unicode_partition
undingen 6a33d15
Merge pull request #1294 from sizeoftank/pr_instance_sqslots_mpslots_…
undingen c1488b5
Enable _tkinter and Tkinter module in Pyston
900753b
Rename pure None to pyston_None, and use Py_None as much as possible. …
d2293a8
Add thread.interrupt_main
be94efc
Test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
[submodule "test/lib/django"] | ||
path = test/lib/django | ||
url = https://github.com/django/django | ||
[submodule "test/lib/virtualenv"] | ||
path = test/lib/virtualenv | ||
url = https://github.com/dropbox/virtualenv | ||
[submodule "test/lib/pycrypto"] | ||
path = test/lib/pycrypto | ||
url = https://github.com/dlitz/pycrypto.git | ||
[submodule "test/lib/gflags"] | ||
path = test/lib/gflags | ||
url = https://github.com/google/python-gflags | ||
ignore = untracked | ||
[submodule "test/lib/sqlalchemy"] | ||
path = test/lib/sqlalchemy | ||
url = https://github.com/zzzeek/sqlalchemy | ||
[submodule "test/lib/pyxl"] | ||
path = test/lib/pyxl | ||
url = https://github.com/dropbox/pyxl.git | ||
ignore = untracked | ||
[submodule "build_deps/libunwind"] | ||
path = build_deps/libunwind | ||
url = https://github.com/pathscale/libunwind.git | ||
ignore = all | ||
[submodule "build_deps/libpypa"] | ||
path = build_deps/libpypa | ||
url = git://github.com/vinzenz/libpypa.git | ||
[submodule "build_deps/lz4"] | ||
path = build_deps/lz4 | ||
url = git://github.com/Cyan4973/lz4.git | ||
[submodule "build_deps/jemalloc"] | ||
path = build_deps/jemalloc | ||
url = git://github.com/jemalloc/jemalloc.git | ||
[submodule "test/lib/decorator"] | ||
path = test/lib/decorator | ||
url = https://github.com/micheles/decorator | ||
[submodule "test/lib/pyinotify"] | ||
path = test/lib/pyinotify | ||
url = https://github.com/seb-m/pyinotify.git | ||
[submodule "test/lib/sqlalchemy_0.5"] | ||
path = test/lib/sqlalchemy_0.5 | ||
url = https://github.com/zzzeek/sqlalchemy | ||
ignore = untracked |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
language: cpp | ||
|
||
compiler: | ||
- clang | ||
- gcc | ||
|
||
env: | ||
matrix: | ||
- TRAVIS_BUILD_TYPE=Debug CCACHE_DIR=$HOME/.ccache_debug | ||
- TRAVIS_BUILD_TYPE=Release CCACHE_DIR=$HOME/.ccache_release | ||
global: | ||
- PYSTON_RUN_ARGS=G | ||
|
||
matrix: | ||
exclude: | ||
- compiler: gcc | ||
env: TRAVIS_BUILD_TYPE=Debug CCACHE_DIR=$HOME/.ccache_debug | ||
|
||
# use travis-ci docker based infrastructure | ||
sudo: false | ||
|
||
cache: | ||
directories: | ||
- $HOME/.ccache_debug | ||
- $HOME/.ccache_release | ||
|
||
addons: | ||
apt: | ||
sources: | ||
- kubuntu-backports | ||
- llvm-toolchain-precise-3.5 | ||
- ubuntu-toolchain-r-test | ||
packages: | ||
- autoconf | ||
- ccache | ||
- clang-3.5 | ||
- cmake | ||
- g++-4.8 | ||
- gdb | ||
- gfortran | ||
- libatlas-dev | ||
- libatlas-base-dev | ||
- libbz2-dev | ||
- libgeoip-dev | ||
- libgmp3-dev | ||
- libmpfr-dev | ||
- liblzma-dev | ||
- libncurses5-dev | ||
- libreadline-dev | ||
- libsqlite3-dev | ||
- libtool | ||
- ninja-build | ||
- python-dev | ||
- texlive-extra-utils | ||
- libcurl4-openssl-dev | ||
- libxml2-dev | ||
- libxslt1-dev | ||
- libssl-dev | ||
- libtk8.5 | ||
- libtcl8.5 | ||
- tcl8.5-dev | ||
- tk8.5-dev | ||
- swig | ||
|
||
before_install: | ||
- if [ "$CC" = "clang" ]; then export CC="clang-3.5" CXX="clang++-3.5"; fi | ||
- if [ "$CC" = "gcc" ]; then export CC="gcc-4.8" CXX="g++-4.8"; fi | ||
- $CXX --version | ||
|
||
install: | ||
- git clone git://github.com/llvm-mirror/llvm.git ~/pyston_deps/llvm-trunk | ||
- git clone git://github.com/llvm-mirror/clang.git ~/pyston_deps/llvm-trunk/tools/clang | ||
- git config --global user.email "[email protected]" | ||
- git config --global user.name "Your Name" | ||
- git submodule update --init --recursive | ||
- mkdir ~/pyston-build && cd ~/pyston-build | ||
- make -C $TRAVIS_BUILD_DIR llvm_up | ||
- bash $TRAVIS_BUILD_DIR/tools/configure_travis.sh | ||
|
||
before_script: | ||
- mysql -e 'create database mysqldb_test charset utf8;' | ||
|
||
script: | ||
- ccache -z | ||
- time ninja -j4 pyston check-deps && PYSTON_RUN_ARGS=G travis_wait 60 ctest --output-on-failure | ||
- ccache -s | ||
- if [ -n "$(git status --porcelain --untracked=no)" ]; then echo "test suite left the source directory dirty"; git status; false; fi | ||
|
||
os: | ||
- linux | ||
# - osx | ||
|
||
notifications: | ||
webhooks: | ||
urls: | ||
- https://webhooks.gitter.im/e/7256425a36658faa8b9b | ||
on_success: change # options: [always|never|change] default: always | ||
on_failure: always # options: [always|never|change] default: always |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
set wildignore+=*.expected_cache,*.pyc,*.out,*.bc,*.d,*.o | ||
|
||
let g:pyston_top = expand('<sfile>:p:h') | ||
command! M execute ":make -C " . g:pyston_top . "/src -j1 COLOR=0 USE_DISTCC=0" | ||
command! L execute ":cfile " . g:pyston_top . "/src/compile.log" | ||
|
||
ca m M | ||
ca l L |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll also need to add any new required libraries to docs/INSTALLING.md