Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nrtest-swmm with mincdd_compare #47

Open
michaeltryby opened this issue Sep 18, 2020 · 0 comments
Open

Update nrtest-swmm with mincdd_compare #47

michaeltryby opened this issue Sep 18, 2020 · 0 comments

Comments

@michaeltryby
Copy link
Contributor

michaeltryby commented Sep 18, 2020

Discussing need for a more "rational" comparison criteria for benchmark results. epanet_mincdd_compare can be found here:

https://github.com/EPANET-Project/epanet-python/blob/dev/nrtest-epanet/nrtest_epanet/__init__.py

So if we wanted to run the mincdd we would need to add it to nrtest-swmm and rebuild. Then in the swmm-nrtestsuite repo update the test description files to call the new comparison routine. Then update the helper scripts with the tolerance we want probably 2 or 3 decimal places of precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant