Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for unicode filenames #70

Open
michaeltryby opened this issue Mar 29, 2021 · 5 comments
Open

Support for unicode filenames #70

michaeltryby opened this issue Mar 29, 2021 · 5 comments
Assignees
@michaeltryby
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@michaeltryby
Copy link
Contributor

Passing a filename containing unicode characters causes ERROR 303.

Bug reported by pyswmm user.
@michaeltryby
Copy link
Contributor Author

michaeltryby commented Mar 29, 2021 •
edited
Loading

One possible solution would be to use _wfopen() in SWMM on Windows.

https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-160

@michaeltryby michaeltryby added bug Something isn't working help wanted Extra attention is needed labels Mar 31, 2021
@michaeltryby michaeltryby self-assigned this Mar 31, 2021
@jennwuu
Copy link
Contributor

jennwuu commented Mar 31, 2021

String must be encoded using Latin-1 before passing to SWMM engine. Previously in older pyswmm versions, six.b() was used before passing to SWMM engine.

@jennwuu
Copy link
Contributor

jennwuu commented Mar 31, 2021

@michaeltryby is dev-unicode branch where you last worked on this?

@michaeltryby
Copy link
Contributor Author

@jennwuu Yes that is is the branch I opened up to work on it.

jennwuu added a commit that referenced this issue May 20, 2021
@jennwuu
Issue #70 temp solution to convert string to byte
c2f41ad
@michaeltryby michaeltryby mentioned this issue Jun 2, 2021
Merged
@abhiramm7
Copy link
Collaborator

@michaeltryby looks like we can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaeltryby michaeltryby

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaeltryby @abhiramm7 @jennwuu