Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mechanism to patch modules after setup #248

Closed
mrbean-bremen opened this issue Jun 30, 2017 · 2 comments
Closed

Add mechanism to patch modules after setup #248

mrbean-bremen opened this issue Jun 30, 2017 · 2 comments
Assignees
@mrbean-bremen
Labels
enhancement

Comments

@mrbean-bremen
Copy link
Member

mrbean-bremen commented Jun 30, 2017 •
edited
Loading

Not sure is this is possible but this would take care of problems with dynamic imports for example in Django (see #199), and problems with cached functions from file system modules (to replace the bad hack currently used to implement #191).
@mrbean-bremen mrbean-bremen self-assigned this Aug 3, 2017
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Aug 5, 2017
@mrbean-bremen
Added dynamic patcher that patches files loaded after setup
f4d2904 
- added modules_to_reload instead of special_names and use it for tempfile
- see pytest-dev#248
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Aug 5, 2017
@mrbean-bremen
Added dynamic patcher that patches files loaded after setup
3f80853 
- added modules_to_reload instead of special_names and use it for tempfile
- see pytest-dev#248
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Aug 5, 2017
@mrbean-bremen
Added dynamic patcher that patches files loaded after setup
dc388af 
- added modules_to_reload instead of special_names and use it for tempfile
- removed tempfile patch
- see pytest-dev#248
mrbean-bremen added a commit to mrbean-bremen/pyfakefs that referenced this issue Aug 5, 2017
@mrbean-bremen
Added dynamic patcher that patches files loaded after setup
ff3e9dc 
- added modules_to_reload instead of special_names and use it for tempfile
- removed tempfile patch
- see pytest-dev#248
mrbean-bremen added a commit that referenced this issue Aug 5, 2017
@mrbean-bremen
Added dynamic patcher that patches files loaded after setup
639c66c 
- added modules_to_reload instead of special_names and use it for tempfile
- removed tempfile patch
- see #248
@mrbean-bremen
Copy link
Member Author

mrbean-bremen commented Aug 6, 2017 •
edited
Loading

@jmcgeheeiv - this change does not work with PyPy3 2.4, which is based on Python 3.2. I commented out PyPy3 in Travis, but I'm now thinking to just drop support for it:

  • there is now a PyPy3 based on Python 3.5 around (which we test)
  • based on some Google searches, it seems that very few people actually use that version
  • it does not work with pyfakefs under Windows

What do you think?

@mrbean-bremen
Copy link
Member Author

Ok, I reverted the changes and added dynamic patching as an experimental feature (which won't work for PyPy3 2.4). Closing the issue.

@mrbean-bremen mrbean-bremen mentioned this issue Jan 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrbean-bremen mrbean-bremen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrbean-bremen