-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for glob.iglob #59
Comments
+1 |
1 similar comment
+1 |
I just checked this, and I actually don't understand why glob is faked out at all. |
- glob/iglob shall work out of the box if faking os/os.path - shall fix pytest-dev#59 and pytest-dev#116
@mrbean-bremen, you don't miss much, but could it be that the mock.patch() usage model requires fake glob.glob? |
@jmcgeheeiv: Sorry, I don't really understand that - could you elaborate on this? Why would it require this? |
@jmcgeheeiv: Ok, my bad - I didn't understand you mentioning the mock.patch usage model. In that model (which I didn't use, as I find the unit test usage model quite convenient), this may indeed be needed. |
- use sources from Python 3.5, slightly adapted to work under Python 2 and use fake file system - fixes pytest-dev#59 and pytest-dev#116
@mrbean-bremen, I agree that removing glob/iglob from skipped names in fake_filesystem_unittest would not affect the mock.patch() usage model. The mock.patch() usage model does not even use that code. Since you have triaged this issue with such flair and élan, could I ask you to remove glob/iglob from skipped names, in the manner you believe most appropriate? |
The glob package in python supports glob and iglob methods. The former creates the file name array immediately, while iglob creates an iterator and lazy evaluates the sequence.
The latter is not yet supported by this library
The text was updated successfully, but these errors were encountered: