prevent Config.add_cleanup callbacks preventing other cleanups running #12982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
fix-config-callbacks
branch
from
aa1e3b3
to
33234ef
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
nicoddemus
reviewed
Nov 21, 2024
Co-authored-by: Bruno Oliveira <[email protected]>
for more information, see https://pre-commit.ci
graingert
commented
Nov 21, 2024
graingert
commented
Nov 22, 2024
nicoddemus
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Thanks @graingert!
Will squash/merge soon to give others a chance to review. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12981