Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_char in test_structmembers fails on s390x #127572

Closed
colesbury opened this issue Dec 3, 2024 · 0 comments
Closed

test_char in test_structmembers fails on s390x #127572

colesbury opened this issue Dec 3, 2024 · 0 comments
Labels
tests Tests in the Lib/test dir

Comments

@colesbury
Copy link
Contributor

colesbury commented Dec 3, 2024 •
edited by bedevere-app bot
Loading

After merging #123211:

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto-pgo/build/Lib/test/test_capi/test_structmembers.py", line 170, in test_char
    self.assertEqual(ts.T_CHAR, "c")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
AssertionError: '\x00' != 'c'
- �
+ c

https://buildbot.python.org/#/builders/509/builds/7885

cc @dpdani @vstinner

Linked PRs
@colesbury colesbury added the tests Tests in the Lib/test dir label Dec 3, 2024
colesbury added a commit to colesbury/cpython that referenced this issue Dec 3, 2024
@colesbury
pythongh-127572: Temporarily skip failing test on s390x
598004b
@bedevere-app bedevere-app bot mentioned this issue Dec 3, 2024
Closed
colesbury added a commit to colesbury/cpython that referenced this issue Dec 3, 2024
@colesbury
pythongh-127572: Fix test_structmembers initialization.
7902c35 
The 'C' format code expects an `int` as a destination (not a `char`).
This led to test failures on big-endian platforms like s390x. Use the
'c' format code, which expects a `char` as the destination (but requires
a Python byte objects intead of a str).
colesbury added a commit to colesbury/cpython that referenced this issue Dec 3, 2024
@colesbury
pythongh-127572: Fix test_structmembers initialization.
9c89bc2 
The 'C' format code expects an `int` as a destination (not a `char`).
This led to test failures on big-endian platforms like s390x. Use the
'c' format code, which expects a `char` as the destination (but requires
a Python byte objects intead of a str).
colesbury added a commit to colesbury/cpython that referenced this issue Dec 3, 2024
@colesbury
pythongh-127572: Fix test_structmembers initialization.
0a547aa 
The 'C' format code expects an `int` as a destination (not a `char`).
This led to test failures on big-endian platforms like s390x. Use the
'c' format code, which expects a `char` as the destination (but requires
a Python byte objects instead of a str).
@bedevere-app bedevere-app bot mentioned this issue Dec 3, 2024
Merged
encukou pushed a commit that referenced this issue Dec 4, 2024
@colesbury
gh-127572: Fix test_structmembers initialization (GH-127577)
6fc6436 
gh-127572: Fix `test_structmembers` initialization.

The 'C' format code expects an `int` as a destination (not a `char`).
This led to test failures on big-endian platforms like s390x. Use the
'c' format code, which expects a `char` as the destination (but requires
a Python byte objects instead of a str).
@vstinner vstinner closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @colesbury