Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build a HACL* module on macOS under Catalina #127897

Closed
aeiouaeiouaeiouaeiouaeiouaeiou opened this issue Dec 13, 2024 · 1 comment
Closed
Labels
3.14 new features, bugs and security fixes build The build process and cross-build OS-mac type-bug An unexpected behavior, bug, or error

Comments

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

aeiouaeiouaeiouaeiouaeiouaeiou commented Dec 13, 2024

Bug report

Bug description:

The recent HACL* change in Python 3.14.0a2 cause local build breakage on macOS below Catalina due to lack of support for aligned_alloc (also memset_s on older macOS <10.9).

Fixes for the affected dependency have already been submitted to the repositories:

CPython versions tested on:

3.14

Operating systems tested on:

macOS

Linked PRs

@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou added the type-bug An unexpected behavior, bug, or error label Dec 13, 2024
@Eclips4 Eclips4 added the OS-mac label Dec 13, 2024
@picnixz picnixz added build The build process and cross-build 3.14 new features, bugs and security fixes labels Dec 13, 2024
gpshead pushed a commit that referenced this issue Dec 18, 2024
gh-127897: Update HACL* module from upstream sources to get:

- Lib_Memzero0.c: don't use memset_s() on macOS <10.9
- Use _mm_malloc() for KRML_ALIGNED_MALLOC on macOS <10.15
- Add LEGACY_MACOS macros, use _mm_free() for KRML_ALIGNED_FREE on macOS <10.15
@gpshead
Copy link
Member

gpshead commented Dec 18, 2024

Thanks for taking this on and working to get the fixes properly into the upstream repos.

FYI - macos catalina 10.15 is end of life and insecure for anyone to have attached to a network. But we do appear to still support building back to 10.13 for some reason so this seemed worthwhile.

Closing as I believe that merge should fix it?

@gpshead gpshead closed this as completed Dec 18, 2024
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
pythongh-127897: Update HACL* module from upstream sources to get:

- Lib_Memzero0.c: don't use memset_s() on macOS <10.9
- Use _mm_malloc() for KRML_ALIGNED_MALLOC on macOS <10.15
- Add LEGACY_MACOS macros, use _mm_free() for KRML_ALIGNED_FREE on macOS <10.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.14 new features, bugs and security fixes build The build process and cross-build OS-mac type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants