Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127335: Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios #127336

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −0
Open

gh-127335: Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios #127336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1cbafe
Add the latest macro constants
rruuaanng Nov 27, 2024
ddbe6e8
Change NEWS
rruuaanng Nov 29, 2024
5434c52
Fix NEWS wording
erlend-aasland Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2024-11-27-23-13-21.gh-issue-127335.IiqYeX.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the
Add the ``TIOCM_OUT1``, ``TIOCM_OUT2``, and ``TIOCM_LOOP`` constants to the

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They seem to make no difference, right?

:mod:`termios` module.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saves_will_go_there.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I don't seem to understand your comment, what did you expect? I read the files you provided, but it seems that they are related to the Linux driver model. If you have questions about this, I can contact the downstream team of the corresponding subsystem for you.

9 changes: 9 additions & 0 deletions Modules/termios.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,6 +1232,15 @@ static struct constant {
#ifdef TIOCM_ST
{"TIOCM_ST", TIOCM_ST},
#endif
#ifdef TIOCM_OUT1
{"TIOCM_OUT1", TIOCM_OUT1},
#endif
#ifdef TIOCM_OUT2
{"TIOCM_OUT2", TIOCM_OUT2},
#endif
#ifdef TIOCM_LOOP
{"TIOCM_LOOP", TIOCM_LOOP},
#endif
#ifdef TIOCNOTTY
{"TIOCNOTTY", TIOCNOTTY},
#endif
Expand Down
Loading