Fix while statements with non-bool conditions in _pyrepl
#127509
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rruuaanng
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
|
This change is minor, I don't think it's necessary to add a NEWS and title-label. |
I think it is. |
But haven't we always advocated not using numbers as a condition? |
|
We don't need a NEWS; users won't see or care about this change. With that being said, this is a cosmetic change. I'll let the repl experts decide if they want to take it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python, it is recommended to use bool values as conditions, but there are still scenarios where integers are used in pyrepl, and we use
while Trueinstead ofwhile 1.(I hope this is not considered a cosmetic change. They were discovered when I was learning pyrepl.)