Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127503: Fix realpath handling in emscripten cli #127632

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Dec 5, 2024

I believe @freakboy3742 checked that the previous version works on macs but I didn't test it correctly locally and it does not seem to work on linux.

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with #127633, I think this makes sense; but as I noted on that ticket I'm having difficulty testing this change.

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit d8d12b3 into python:main Dec 9, 2024
54 checks passed
@hoodmane hoodmane deleted the emscripten-fix-realpath branch December 9, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants