Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127353: Allow to force color output on Windows V2 #127926

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PalmtopTiger
Copy link
Contributor

@PalmtopTiger PalmtopTiger commented Dec 13, 2024

This PR allows to force color output on Windows and brings the behavior of can_colorize function into compliance with POSIX. Second version of #127354 with fixed tests.

@PalmtopTiger
Copy link
Contributor Author

@hugovk, could you check this PR please?

@ZeroIntensity ZeroIntensity added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 13, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit a50e877 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 13, 2024
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good so far!

The two current buildbot failures are unrelated and also happen elsewhere, and there might be a third unrelated to come, but all the other buildbots are now passing. 👍

Lib/test/test__colorize.py Outdated Show resolved Hide resolved
@hugovk hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 14, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 6946167 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants