-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement flag to allow typechecking of untyped modules #17712
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
5763e64
to
6491313
Compare
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
@hauntsaninja can you tell me by any chance if there's anything I'm missing/I should do to get a review here? |
Ping. Can someone review this? @JelleZijlstra can you help me with this? |
Ping. @hauntsaninja @JelleZijlstra can you tell me what I need to do to get a review here? |
Mypy development is unfortunately under-resourced and personally I don't have much time available to review PRs. I'd advise you to wait and hopefully a committer will come along and review this. |
I feel like this feature is crucial and affects way too many people for it to be ignored. Using Could this at least get a CR, if improvements are needed then the community can follow up on issues for the PR. ❤️ |
I can try to review this -- possibly next week. It would help if the merge conflict was fixed. |
Thanks for the comment, didn't notice the merge conflict. I wish there were notifications for this... anyway, fixed. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think the per-module handling isn't quite right, in particular, I'm not sure it handles globs correctly. I'd also vote for a slightly more specific name, maybe something like --follow-untyped-imports
. This matches the untyped-import error code the current implementation will silence.
@hauntsaninja thanks for the feedback! You're right, this wasn't handling globs properly. In the process of fixing that, I also noticed that my solution was more complicated than necessary and simplified it a bit... Regarding the name: it seems there was quite a lot of discussion about how the config option should be called on the original issue, so I wasn't sure what to pick. Yours definitely sounds better though, so changed it to that for now. |
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Add a flag and config ini options
"enable_installed_packages"
. Setting it toTrue
instructs mypy to typecheck also modules that do not have stubs or apy.typed
marker.Fixes #8545