Improve type annotations in Flask-Cors stubs #12596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Aug 26, 2024
stubs/Flask-Cors/flask_cors/core.pyi
Outdated
| RegexObject: type[Pattern[str]] | ||
| DEFAULT_OPTIONS: _Options | ||
|
|
||
| ACL_ORIGIN: Final[str] = "Access-Control-Allow-Origin" |
There was a problem hiding this comment.
Nit: If you have a default, you don't need to specify the type:
ACL_ORIGIN: Final = "Access-Control-Allow-Origin"(Here and below.)
We should really have a flake8 warning for that. I filed PyCQA/flake8-pyi#499.
There was a problem hiding this comment.
Well, everything will be fine now!
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@srittau As promised, I have added the constants.