Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dead link in https://github.com/pytorch/torchchat/blob/main/docs/quantization.md #1385

Open
yanbing-j opened this issue Nov 19, 2024 · 4 comments
Open

Update dead link in https://github.com/pytorch/torchchat/blob/main/docs/quantization.md #1385

yanbing-j opened this issue Nov 19, 2024 · 4 comments
Assignees
@Jack-Khuu
Labels
documentation Improvements or additions to documentation Quantization Issues related to Quantization or torchao

Comments

@yanbing-j
Copy link
Contributor

🐛 Describe the bug

There is a dead link https://github.com/pytorch/torchchat/blob/main/torchchat/utils/quantize.py#L1260-L1266 in https://github.com/pytorch/torchchat/blob/main/docs/quantization.md like See the available quantization schemes [here](https://github.com/pytorch/torchchat/blob/main/torchchat/utils/quantize.py#L1260-L1266).. Could you please help update it to show the quantization schemes examples?

Versions
@yanbing-j
Copy link
Contributor Author

cc @mikekgfb @mingfeima

@Jack-Khuu
Copy link
Contributor

Link looks live to me (redirects to code)?

That said we doc in the file can be polished

cc: @vmpuri

@Jack-Khuu Jack-Khuu added documentation Improvements or additions to documentation Quantization Issues related to Quantization or torchao labels Nov 19, 2024
@yanbing-j
Copy link
Contributor Author

In main branch, torchchat/utils/quantize.py only has 942 lines.

@Jack-Khuu
Copy link
Contributor

Ah good catch

Jack-Khuu added a commit that referenced this issue Nov 22, 2024
@Jack-Khuu
Update quantization.md link to quantize.py
f32584f 
#1385
@Jack-Khuu Jack-Khuu mentioned this issue Nov 22, 2024
Open
@Jack-Khuu Jack-Khuu assigned Jack-Khuu and unassigned vmpuri Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jack-Khuu Jack-Khuu

Labels
documentation Improvements or additions to documentation Quantization Issues related to Quantization or torchao
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jack-Khuu @vmpuri @yanbing-j