-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose metadata as dataclasses - first episode #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data within SimpleVideoDecoder
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Jun 26, 2024
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@NicolasHug merged this pull request in c82f142. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Implements docs.google.com/document/d/1OislJC2eeaI2X38Ufy8fDRJDrEj1lcSNtZ-8L-CeQm8/edit from @scotts, with the amendments recently suggested after first review rounds.
Main changes:
_core.get_video_metadata()
(still private within_core
).stream_metadata
attribute ofSimpleVideoDecoder
_get_container_json_metadata(decoder)
_get_stream_json_metadata(decoder, stream_index)
Notes:
get_json_metadata()
C++ and Python functions untouched. They are currently in use internally, and it'll be easier to migrate that internal code in a separate diff.Still TODO, in following diffs:
probe_video_metadata_headers()
from the proposal.num_frames_computed
andnum_frames_retrieved
. There's a TODO for thatbit_rate
andduration_seconds
properties. There are TODOs for that.