Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [REQUEST] - Update tutorials with device-generic APIs #3113

Closed
albanD opened this issue Oct 24, 2024 · 3 comments · Fixed by #3190
Closed

💡 [REQUEST] - Update tutorials with device-generic APIs #3113

albanD opened this issue Oct 24, 2024 · 3 comments · Fixed by #3190
Assignees

Comments

@albanD
Copy link
Contributor

albanD commented Oct 24, 2024

🚀 Describe the improvement or the new tutorial

We should use the latest device-generic APIs when they come out in 2.6 in all tutorials to improve readability.

Existing tutorials on this topic

https://pytorch.org/tutorials/beginner/basics/buildmodel_tutorial is an example of one we should update. There is most likely more.

Additional context

cc @guangyey that might be a good follow up to consider before 2.6

@guangyey
Copy link
Contributor

I am delighted to take on this task. I couldn't self-assign, please assign it to me.

@shink
Copy link
Contributor

shink commented Oct 25, 2024

I'd love to contribute as well, but do we have a list of which APIs should be replaced and with what?

@AndyDralle
Copy link

Just a note from a user-perspective: It's very confusing to have the tutorials updated before the features are actually available.
I installed Pytorch yesterday, in order to try out https://pytorch.org/tutorials/beginner/transfer_learning_tutorial.html. By chance, this happened to be directly after the documentation was updated, I suppose.

Anyway, pip gave me torch 2.5.1, which means that the tutorial code doesn't actually work for me. And the problem isn't google-able, since it's so new, and the documentation doesn't hint at this 2.6 version requirement either. I only found this explanation, because I happened to look the tutorial page up on GitHub, where I noticed this very recent commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants