Build docker image #2542
Build docker image #2542
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2542
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 5ae8ead with merge base 9ceac50 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
clee2000
force-pushed
the
csl/dexperiment
branch
2 times, most recently
from
5a72eee to
a75016d
Compare
clee2000
force-pushed
the
csl/dexperiment
branch
from
0f4db08 to
f2d52bd
Compare
| MAJOR_PYTHON_VERSION=$(echo "$ANACONDA_PYTHON_VERSION" | cut -d . -f 1) | ||
| MINOR_PYTHON_VERSION=$(echo "$ANACONDA_PYTHON_VERSION" | cut -d . -f 2) | ||
|
|
||
| CONDA_FILE="Miniconda3-latest-Linux-x86_64.sh" |
There was a problem hiding this comment.
Not sure if latest is such a good idea, perhaps one can specify the version here.
Also, why not depend on the system python? (Should be 3.8 or something like that)
| vim \ | ||
| unzip \ | ||
| gdb \ | ||
| rsync \ |
There was a problem hiding this comment.
It does not hurt, but why?
| rsync \ |
| apt-get install -y --no-install-recommends \ | ||
| build-essential \ | ||
| ca-certificates \ | ||
| cmake=3.16* \ |
There was a problem hiding this comment.
Why do we need cmake to build tutorials?
| cmake=3.16* \ |
| sudo \ | ||
| vim \ | ||
| jq \ | ||
| vim \ |
There was a problem hiding this comment.
I really like vim, but installing it once is sufficient
| vim \ |
Downloading pip dependencies takes 2-4 min, but downloading the new docker image takes +1min from the pytorch one Not sure how downloading all dependencies to a new image takes in comparison to pulling docker image Docker image scripts are copied from pytorch, I tried to remove stuff but there's definitely a lot left over
Downloading pip dependencies takes 2-4 min, but downloading the new docker image takes +1min from the pytorch one
Not sure how downloading all dependencies to a new image takes in comparison to pulling docker image
Docker image scripts are copied from pytorch, I tried to remove stuff but there's definitely a lot left over