Attempt to fix PyPy/CPython 3.8+ compatibility #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conda-forge has been trying for a long time to build a PyPy binary of aggdraw, but has been failing:
conda-forge/aggdraw-feedstock#25
The error is basically:
It turns out
printfunc
is deprecated and unused, but was repurposed in Python 3.8:https://peps.python.org/pep-0590/#changes-to-the-pytypeobject-struct
I found a PR in swig that had to make the same type of update (swig/swig#2264) so I copied that simple logic here. Once merged I'll have to cherry-pick it to the
maint
branch so it can be released for the current stable version.I should be able to turn on PyPy wheel builds in CI too.