-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert AreaDefinitions to odc geoboxes #545
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8f5fe3b
feat: add to_odc_geobox method
BENR0 4b02a02
Add: odc-geo to extras list.
BENR0 bb4d79c
fix: geobox pixel snapping.
BENR0 5e600a1
test: add geobox conversion test.
BENR0 fcf296b
refactor: add exception for none installed odc-geo.
BENR0 ec53f26
fix: odc-geo not in ci environment dependency list.
9381bff
Merge branch 'main' into feat_to_odc_geobox
BENR0 87b2bf1
Merge branch 'main' into feat_to_odc_geobox
acff8b9
Merge branch 'feat_to_odc_geobox' of github.com:BENR0/pyresample into…
BENR0 84a6deb
refactor: remove unnecessary setup_requires.
28c6f80
fix: odc-geo not in test_requires list.
c043b97
refactor: use odc Resolution class.
09c35fd
refactor: move odc-geo import to top, add test for missing odc-geo.
e560f1c
Merge branch 'main' into feat_to_odc_geobox
BENR0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,3 +27,4 @@ dependencies: | |
- pytest-lazy-fixture | ||
- importlib-metadata | ||
- sphinx-reredirects | ||
- odc-geo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we xfail or skip if odc is missing? I think pytest has a decorator specifically for skipping if import fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good Idea. I will also add a test for missing
odc-geo
since that is not tested yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And thanks for using the
create_test_area
fixture. It makes my work on Pyresample 2.0 much easier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test for the case where
odc-geo
is not installed and changed the setup to include it as a requirement for testing. I thought about it and I think the test should not be skipped ifodc-geo
is not installed insteadodc-geo
should be required for testing as it is now.