Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steps_per_scene is a non-obvious cap on video length #37

Open
usergenic opened this issue Mar 22, 2022 · 2 comments
Open

steps_per_scene is a non-obvious cap on video length #37

usergenic opened this issue Mar 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@usergenic
Copy link

I was doing a long video render (6 minutes) and found my runs were arbitrarily stopping at around 2000 frames. After digging through the code it looks like they stopped because the steps_per_scene value was arbitrarily set to 60000 or so and I was doing 30 steps per frame.

This steps_per_scene value seems kind of non obvious to me. Consider dropping this limit at least for Video Source?

@usergenic
Copy link
Author

oh okay lol just realized that even with video source an arbitrarily high number of steps_per_scene will result in near endless rendering. so what we really need is a way to calculate the steps_per_scene number based on the length of the video input.

@dmarx
Copy link
Member

dmarx commented Mar 23, 2022

I like your thinking here. I don't think it should be too hard to add a setting for something like "process all frames in video source". conversely, could probably add a warning or something along those lines to alert the user if the steps per scene is too low to run the length of the video.

@dmarx dmarx added the enhancement New feature or request label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants