-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to check if a cached image isn't compared to an image during all tests #28
Comments
I believe this is If I set
|
I think to have that feature, we are going to have to use The problem is to check at the end of the tests that there is no leftover. |
This might be a solution: |
I think it is a poor name for this argument. I think it does what the help message says pytest-pyvista/pytest_pyvista/pytest_pyvista.py Lines 23 to 27 in 0ad5b8c
|
I would propose to change the name then. |
It would be very useful to have an option to check that all cached images were compared during a test. This is a complement to checking that all comparisons have an image in the cache.
This is tricky if tests are skipped for any reason. So, it would be only useful if there is a canonical version for which no test is skipped. I'm not sure if this is the case today for
pyvista
. It is very possible that at least one plotting test is skipped on every vtk version. But, this could be useful for downstream libs that have less wide-open vtk version support.The text was updated successfully, but these errors were encountered: