Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly testing of user guide notebooks #330

Open
hakonanes opened this issue May 10, 2022 · 5 comments
Open

Weekly testing of user guide notebooks #330

hakonanes opened this issue May 10, 2022 · 5 comments
Labels
dev Package maintenance documentation Relates to the documentation

Comments

@hakonanes
Copy link
Member

The new weekly testing of user guide notebooks using nbval works as expected. The action log is here.

The only notebook with cell outputs stored is the "Clustering orientations" one. I would expect all notebooks that haven't stored cell outputs to pass, however some cells in the two other clustering notebooks fail. I'll look into this when I find the time.

@hakonanes hakonanes added dev Package maintenance documentation Relates to the documentation labels May 10, 2022
@harripj
Copy link
Collaborator

harripj commented May 10, 2022

Looks like sklearn needs to be installed when using the action: https://github.com/pyxem/orix/runs/6346988629?check_suite_focus=true#step:6:1926

I will add this to the action and run again.

EDIT
I think we need to add the extra "doc" dependencies to the pip install action.

@hakonanes
Copy link
Member Author

Good point. I'll fix this now, as I have to fix setup.py for uploading to PyPI.

@hakonanes
Copy link
Member Author

Fantastic, everything works (log) except the cell in the "Clustering orientations" notebook printing the time for get_distance_matrix(), which we shouldn't expect to be the same for my machine (slightly faster) and the GitHub runner.

@harripj
Copy link
Collaborator

harripj commented May 10, 2022

We wouldn't expect this to be consistent, but it looks like we can add the tag nbval-ignore-output to the code cell to stop nbval producing the error whilst running the action: https://nbval.readthedocs.io/en/latest/#Using-tags-instead-of-comments

@hakonanes hakonanes reopened this May 10, 2022
@hakonanes
Copy link
Member Author

Yes, we should add that metadata to the relevant cell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Package maintenance documentation Relates to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants