Arcgis services description

[arx-it]

Add a description type to arcgis rest services browser list (ex: Feature Service or MapService)

[nyalldawson]

Have you got a screenshot what this looks like?

[arx-it]

Yes

[arx-it]

It add for each arcgis rest service if is a MapService or Feature Service

[nyalldawson]

Thanks for the contribution, but I'm a -1 to this change. I think it adds a lot of extra text to the browser just to show something which is already visible via the icon.

[arx-it]

Several entities have asked us for this change to quickly see the type of service, it is just the additional text in brackets (FeatureService or MapService)...

[nyalldawson]

What about putting this in the tooltip?

The other issue I have is that some datasets are exposed as both feature services AND map services. QGIS shows two items for these under the same group. If you add the service type to the group, then it's misleading for these items...

[arx-it]

I will speak with my colleagues about it...
Keep in touch

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

[jlo-arxit]

Hi,
Quick follow-up on this PR after some discussion with the requestor.
We don't really understand your comments @nyalldawson (Aug 22), see our screenshot, it doesn't seem to us that both feature service and map service of a same dataset:

• have different icons > All services have the same kind of database icon
• are grouped > All services are listed in a flat way under ArcGIS Server connexion

... or perhaps they now are in a latest QGIS version ? (sorry if it the case)

Anyway, if you think that adding some text in ( ) after service name make the UI too dense, we can indeed propose to use specific icons for feature / map / image services

[arx-it]

Reopen pull request

[github-actions]

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 62e36b2)

[nyalldawson]

@arx-it

Let's take an example:

https://gislegacy.scc.qld.gov.au/arcgis/rest/services/Biota/Biota_SCRC/MapServer

This is how it's shown in QGIS:

The datasets on the server have BOTH the "export map" and "query" capabilities, so they can be accessed using either the mapserver or feature server protocols. Accordingly it makes no sense to append either "Feature Server" or "Map Server" on the "Biota_SCRC" group, as the group contains both service types.

You can also see in the screenshot that different icons are used for mapserver (raster)/feature server (vector) versions of these layers.

[jlo-arxit]

@nyalldawson
Thanks for your reply.
I think there is a confusion between ESRI "feature layers" (what you are talking about) and "feature/map services" (what we are talking about)

Your screenshot is showing the multiple feature layers inside a single map service called Biota_SCRC and reachable at the following endpoint :
https://gislegacy.scc.qld.gov.au/arcgis/rest/services/Biota/Biota_SCRC/MapServer
Note the end of the URL : "MapServer" means that you are targetting a single ArcGIS Server service

What our development intend to adress is the distinction between map services, feature services and image services inside a global ArcGIS Server endpoint such as : https://xxx/arcgis/rest/services
This endpoint list all services available in the targetted ArcGIS Server, not only one. Please note this database icon, same one for all services in the endpoint, whatever there type (mapserver / featureserver / imageserver)

Here is an example :

In QGIS :

• for Biota map service, you are right, there is an icon distinction between the different feature layers of this single ArcGIS map service endpoint. The icon depends on how you want to use the feature layer : image/map or feature/query (in this second case, also an icon distinction based on geometry type)
• but our concern is one level higher, we need distinction between map services, feature services and image services when we are referencing a global ArcGIS rest endpoint in QGIS

Here an example of what we can do to differentiate map service, feature service and image services (quick work, surely need to rework icons) :

I hope it's clearer

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[jlo-arxit]

A little up before it gets closed ...
Thanks

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[jlo-arxit]

A little up before it gets closed ...
Thanks

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[jlo-arxit]

Up

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[jlo-arxit]

Up

[olivierdalang]

@jlo-arxit Hey ! You still have failures on the CI, I guess you'll have better chances getting another review and approval once fixed. From a quick look at the logs you probably miss some docstrings and haven't updated the SIP bindings (see https://docs.qgis.org/3.34/en/docs/developers_guide/codingstandards.html#generating-the-sip-file - I hope it's up to date, haven't used this in a long while)

edit: ping @arx-it