Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disentangle doesn't work on main #30

Open
Technici4n opened this issue Oct 10, 2023 · 1 comment
Open

disentangle doesn't work on main #30

Technici4n opened this issue Oct 10, 2023 · 1 comment

Comments

@Technici4n
Copy link

Technici4n commented Oct 10, 2023

Hello,

I tried using the latest version of Wannier.jl (main branch), however it looks like the refactoring wasn't fully completed:

U = disentangle(wannier_model)
type Model has no field n_bands

Stacktrace:
 [1] getproperty(model::Wannier.Model{Float64}, sym::Symbol)
   @ Wannier [C:\Users\bruno\.julia\dev\Wannier\src\model.jl:84](file:///C:/Users/bruno/.julia/dev/Wannier/src/model.jl:84)
 [2] disentangle(p::SpreadPenalty, model::Wannier.Model{Float64}; random_gauge::Bool, f_tol::Float64, g_tol::Float64, max_iter::Int64, history_size::Int64)
   @ Wannier [C:\Users\bruno\.julia\dev\Wannier\src\localization\disentangle.jl:640](file:///C:/Users/bruno/.julia/dev/Wannier/src/localization/disentangle.jl:640)
 [3] disentangle(p::SpreadPenalty, model::Wannier.Model{Float64})
   @ Wannier [C:\Users\bruno\.julia\dev\Wannier\src\localization\disentangle.jl:631](file:///C:/Users/bruno/.julia/dev/Wannier/src/localization/disentangle.jl:631)
 [4] disentangle(model::Wannier.Model{Float64}; kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ Wannier [C:\Users\bruno\.julia\dev\Wannier\src\localization\disentangle.jl:731](file:///C:/Users/bruno/.julia/dev/Wannier/src/localization/disentangle.jl:731)
 [5] disentangle(model::Wannier.Model{Float64})
   @ Wannier [C:\Users\bruno\.julia\dev\Wannier\src\localization\disentangle.jl:731](file:///C:/Users/bruno/.julia/dev/Wannier/src/localization/disentangle.jl:731)
 [6] top-level scope
   @ [c:\Users\bruno\Documents\unif-epfl\q5\pdm\playground\simple_graphene_experiments.ipynb:3](file:///C:/Users/bruno/Documents/unif-epfl/q5/pdm/playground/simple_graphene_experiments.ipynb:3)

Not a big problem, I'll go back to 0.3.1 for now.

@qiaojunfeng
Copy link
Owner

Thanks for your interest in this package!
Yes I am doing a full refactorization, but unfortunately, I wasn't able to fully work on this recently.
For now please use the old version, I will release a new one when everything is in good shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants