-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spglib compat issue with 0.3.1 #34
Comments
Sure, do you need any other changes? Maybe when that PR is almost ready, we figure out all the necessary changes, and make a new release? |
I didn't encounter issues with 0.3.1, so just this change is enough for me at the moment at least. |
After a bit more thinking, a 0.3.2 release with just the spglib dependency bump would be fine if you don't mind! |
Thanks! Could you test this branch https://github.com/qiaojunfeng/Wannier.jl/tree/fix/spglib ? |
Tested and that version works :) |
Done! Here it is https://github.com/qiaojunfeng/Wannier.jl/releases/tag/v0.3.2 |
Hello!
When trying to integrate Wannier 0.3.1 with DFTK (JuliaMolSim/DFTK.jl#899), we noticed that DFTK requires Spglib version
0.8.4
exactly. Unfortunately, Wannier 0.3.1 still requires version0.6
of Spglib.Maybe you could release a 0.3.2 version of Wannier that also supports Spglib 0.7 and 0.8? :)
The text was updated successfully, but these errors were encountered: