Circuit to pulse: nomenclature and functionalites

[visagim]

I'm going through the CircuitToPulses class in qililab and I had some things I felt would be nice to discuss about naming conventions and some parts of the code where I'm not clear on what it is doing what it is doing. These are probably not super important things but I feel it'd be nice to agree on some things like naming conventions so that code is more readable across classes.

1. Non-measurement gates are called "control_gates" i feel this is ok, since they are controlling qubits after all (vs reading them). But it can also be quite confusing, specially since all gates also have gate.control_qubits; then to access control qubits for a list of control_gates one has to do "control_gate.control_qubits()"
   

   qililab/src/qililab/pulse/circuit_to_pulses.py

   Lines 44 to 47 in 0f634a0

   	readout_gates = circuit.gates_of_type(M)
   	control_gates = [
   	gate for (i, gate) in enumerate(circuit.queue) if i not in [idx for (idx, _) in readout_gates]
   	]

2. Do we actually need to check that amplitude and duration are (int, float, np.number)? (and why here) If yes, also why here, shouldn't this be checked when gate_setttings is created (that is, at HardwareGateFactory) ?
   

   qililab/src/qililab/pulse/circuit_to_pulses.py

   Lines 107 to 132 in 0f634a0

   	def _get_gate_settings_with_master_values(self, gate: Gate):
   	"""get gate settings with master values"""
   	gate_settings = HardwareGateFactory.gate_settings(
   	gate=gate,
   	master_amplitude_gate=self.settings.master_amplitude_gate,
   	master_duration_gate=self.settings.master_duration_gate,
   	)
   	if (
   	not isinstance(gate_settings.amplitude, float)
   	and not isinstance(gate_settings.amplitude, int)
   	and not isinstance(gate_settings.amplitude, np.number)
   	):
   	raise ValueError(
   	f"Value amplitude: {gate_settings.amplitude} MUST be a float or an integer. "
   	f"Current type is {type(gate_settings.amplitude)}."
   	)
   	if (
   	not isinstance(gate_settings.duration, float)
   	and not isinstance(gate_settings.duration, int)
   	and not isinstance(gate_settings.duration, np.number)
   	):
   	raise ValueError(
   	f"Value duration: {gate_settings.duration} MUST be an integer. "
   	f"Current type is {type(gate_settings.duration)}."
   	)

3. From the runcard definitions I get why duration might have to be an int. However just casting a float to int without warning or anything seems dangerous. Are there any considerations for this? (eg. maybe it'd be better to round up, or even raise an error if duration is not an int)
   

   qililab/src/qililab/pulse/circuit_to_pulses.py

   Lines 133 to 135 in 0f634a0

   	if isinstance(gate_settings.duration, float):
   	gate_settings.duration = int(gate_settings.duration)
   	return gate_settings

(I might add more comments in the future as I see them, feel free to discuss)