Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS fix breaks static assets #13

Open
s3u opened this issue Feb 15, 2012 · 1 comment
Open

XSS fix breaks static assets #13

s3u opened this issue Feb 15, 2012 · 1 comment
Assignees

Comments

@s3u
Copy link
Member

s3u commented Feb 15, 2012

The fix made to deal with https://gist.github.com/1794561 breaks the console.

The way the 404 handler works prevents site's static assets.

@ghost ghost assigned s3u Feb 15, 2012
@s3u
Copy link
Member Author

s3u commented Mar 15, 2012

To bypass this, edit node_modules/ql.io-app/node_modules/ql.io-console/app.js and
comment out the function below the comment // 404 Handling.

The fix is coming from connect 2.0. But express 2.0 which depends on connect 2.0 is not final yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant