Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit clause inconsistency #506

Open
s3u opened this issue Jun 13, 2012 · 2 comments
Open

Limit clause inconsistency #506

s3u opened this issue Jun 13, 2012 · 2 comments
Assignees
Labels

Comments

@s3u
Copy link
Member

s3u commented Jun 13, 2012

Try

select * from finditems where keywords = 'ipad 2' limit 3

on ql.io/console. This works as expected as the table created as

create table finditems
 on select get from 'http://svcs.ebay.com/services/search/FindingService/v1?OPERATION-NAME=findItemsByKeywords&SERVICE-VERSION=1.8.0&GLOBAL-ID={globalid}&SECURITY-APPNAME={apikey}&RESPONSE-DATA-FORMAT={format}&REST-PAYLOAD&keywords={^keywords}&paginationInput.entriesPerPage={limit}&paginationInput.pageNumber={pageNumber}&outputSelector%280%29=SellerInfo&sortOrder={sortOrder}'
   with aliases format = 'RESPONSE-DATA-FORMAT', json = 'JSON', xml = 'XML'
   using defaults format = 'XML', globalid = 'EBAY-US', sortorder ='BestMatch',
   apikey =  "{config.eBay.apikey}", limit = 10, pageNumber = 1
   resultset 'findItemsByKeywordsResponse.searchResult.item';

Here limit is mapped to a token {limit}.

If the token is not mapped, the limit clause has no effect. This is confusing.

@hochang
Copy link
Member

hochang commented Jun 19, 2012

In fact, the param that does page limitation has various names across different apis. It requires human understanding to map limit to the corresponding param

@ghost ghost assigned hochang Nov 26, 2012
@jasxie
Copy link

jasxie commented Nov 26, 2012

Let's discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants