Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported_platforms for plugins #1220

Open
brynary opened this issue Nov 26, 2024 · 0 comments
Open

Add supported_platforms for plugins #1220

brynary opened this issue Nov 26, 2024 · 0 comments
Labels

Comments

@brynary
Copy link
Member

brynary commented Nov 26, 2024

Certain plugins may not be compatible with all platforms that we run on. For example, we have identified issues with Hadolint on MacOS, and we have identified issues with swiftlint on non-MacOS systems.

Add a supported_platforms array key to the plugin definition:

[plugins.definitions.swiftlint]
supported_platforms = ["macos"]
# ...

Valid array values are "macos", "linux", and "windows".

If supported_platforms is empty, treat it as all platforms. If supported_platforms is not blank:

  1. qlty init should only enable the plugin if it is on a supported platform.
  2. The planner should skip the plugin when running on a supported platform (if the platform is unsupported on the current platform, log an info!)
@brynary brynary changed the title Plugin platform targets Add supported_platforms for plugins Nov 26, 2024
@lsegal lsegal added the feature label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants