Remove check for asymmetry, and open a separate issue #1462.

quanteda · Oct 24, 2018 · 4113eda · 4113eda
1 parent eb5b541
commit 4113eda
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/R/textplot_network.R b/R/textplot_network.R
@@ -147,8 +147,6 @@ as.network.default <- function(x, ...) {
 #' @seealso \code{\link[network]{network}}
 as.network.fcm <- function(x, min_freq = 0.5, omit_isolated = TRUE, ...) {
 
-    if (!x@tri)
-        stop("Cannot plot ordered fcm")
     if (nfeat(x) > 1000) stop('fcm is too large for a network plot')
     f <- x@margin
     x <- remove_edges(x, min_freq, omit_isolated)

diff --git a/tests/testthat/test-textplot_network.R b/tests/testthat/test-textplot_network.R
@@ -67,13 +67,13 @@ test_that("remove_edges is working", {
 
 })
 
-test_that("error when fcm is ordered", {
-
-    mt <- fcm(c("a a b", "a b", "c b"), ordered = FALSE)
-    expect_silent(as.network(mt))
-    mt2 <- fcm(c("a a b", "a b", "c b"), ordered = TRUE)
-    expect_error(as.network(mt2),
-                 "Cannot plot ordered fcm")
-})
+# test_that("error when fcm is ordered", {
+#     
+#     mt <- fcm(c("a a b", "a b", "c b"), ordered = FALSE)
+#     expect_silent(as.network(mt))
+#     mt2 <- fcm(c("a a b", "a b", "c b"), ordered = TRUE)
+#     expect_error(as.network(mt2),
+#                  "Cannot plot ordered fcm")
+# })