Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Unintentional replacement of the version definition #693

Closed
timonzi opened this issue Jan 7, 2025 · 2 comments · Fixed by #694
Closed

Documentation: Unintentional replacement of the version definition #693

timonzi opened this issue Jan 7, 2025 · 2 comments · Fixed by #694
Assignees
Labels
backport-3.5.x bug Something isn't working docs Improvements or additions to documentation

Comments

@timonzi
Copy link

timonzi commented Jan 7, 2025

Within the documentation (section: Installation) the version definition is replaced for quarkus-bom and quarkus-artemis-bom by the values, which are defined in attributes.adoc (I think).

<dependencyManagement>
    <dependencies>
        <dependency>
            <groupId>org.apache.activemq</groupId>
            <artifactId>artemis-bom</artifactId>
            <version>${artemis-version}</version>
            <type>pom</type>
            <scope>import</scope>
        </dependency>
        <dependency>
            <groupId>io.quarkus.platform</groupId>
            <artifactId>quarkus-bom</artifactId>
            <version>$3.17.4</version>
            <type>pom</type>
            <scope>import</scope>
        </dependency>
        <dependency>
            <groupId>io.quarkiverse.artemis</groupId>
            <artifactId>quarkus-artemis-bom</artifactId>
            <version>$3.6.0</version>
            <type>pom</type>
            <scope>import</scope>
        </dependency>
    </dependencies>
</dependencyManagement>

Beside of this you mention below

We recommend to set properties quarkus.version and artemis.version to the versions you are using/need to use. We also recommend to align artemis.version with the artemis server version used.

I think it should be quarkus-version and artemis-version.

@turing85
Copy link
Contributor

turing85 commented Jan 7, 2025

Hmm... probably just a missing \ before the $ or the { to prevent replacement...

turing85 added a commit that referenced this issue Jan 7, 2025
@turing85 turing85 self-assigned this Jan 7, 2025
@turing85 turing85 added bug Something isn't working docs Improvements or additions to documentation backport-3.5.x labels Jan 7, 2025
turing85 added a commit that referenced this issue Jan 7, 2025
@turing85
Copy link
Contributor

turing85 commented Jan 7, 2025

@timonzi care to take a look at #694?

turing85 added a commit that referenced this issue Jan 7, 2025
…ed with the predefined attributes.

Resolves #693

(cherry picked from commit 3b80607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.5.x bug Something isn't working docs Improvements or additions to documentation
Projects
None yet
2 participants