@RateLimited should be repeatable

[mschorsch]

The @RateLimited annotation should be repeatable.

Example:

@RateLimited(bucket = "global")
@RateLimited(bucket = "per-user", identityResolver = IpResolver::class)
@ApplicationScoped
class MyClass {

    //...
}

see also: https://stackoverflow.com/questions/35951519/java-8-repeatable-custom-annotations

[rmanibus]

I think this is a valuable use case, but it can lead to some interesting edge cases:
in case we have multiple pods attached to a method
If one of the bucket is empty, should we still consume token from the other one ?
If multiple bucket are empty, what wait time are we returning ? (for this one, max function is probably fine)
Also, should we fail if the same bucket is attached multiple time to a method ?

[mschorsch]

If one of the bucket is empty, should we still consume token from the other one ?

No. As a user i would expect that If one condition ist not met then the request should fail.

If multiple bucket are empty, what wait time are we returning ? (for this one, max function is probably fine)

Yes, max function should be fine.

Also, should we fail if the same bucket is attached multiple time to a method ?

Yes.

[rmanibus]

@mschorsch sounds reasonable to me. Do you want to contribute that?