-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IncompatibleClassChangeError: TenantConfigContext #54
Comments
@UbiquitousBear could you prepare a small Maven reproducer? I'm having a look but from what I can see, the code is still referencing a class (there's a class for compatibility AFAICS) so I'm not entirely sure what's going on. |
@gsmet it is: https://github.com/UbiquitousBear/oidc-proxy-reproduer It can be ran using:
|
@UbiquitousBear The pull requests to update Quarkus versions are succeeding, they involve running integration tests |
Yeah, what I'm wondering is if we have to rebuild a release with a newer version. I wouldn't be surprised if we broke binary compatibility. My guess is that pushing a new version would fix it (but I haven't checked!). |
Hi @gsmet Do you mean, releasing a new version of |
Yes. My guess is that there's a binary incompatibility and we need new jars linking to current version of Quarkus. And let's make it a minor as my guess is that they won't be compatible with the previous versions. Probably, a good idea to add a compatibility table in the README as people with 3.15 LTS will need to stay on the current version. |
Thanks @gsmet, we have 3 issues opened (apart from this one) so I'll get 0.2.0 out hopefully next week |
Or you could release now to unblock people and do another next week with some additional fixes? |
I’ve only seen the exception when it comes to binary incompatibilities |
@gsmet You are right, I was thinking I could it do it rather quickly in the morning, thinking of doing a quick update related to HtmlIUnit coordinates, but during that I found out the integration module was not in the list of modules at the root pom level, the test became stale and failing most likely due to the Keycloak version update (there is another one in deployment), so I need to fix it... |
Due to this change, specifically with
TenantConfigContext
now becoming an interface, a quarkus application with platform >= 3.16.0 will not start receiving the following error:OidcProxy
is no longer initing, due the above on this line.The text was updated successfully, but these errors were encountered: