Migrate hard coded images to Maven properties #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtroitsk
changed the title
|
@michalvavrik could you take a look at this? |
|
@rsvoboda I talked to @gtroitsk and suggested what he should do in FW first, before this (basically we agreed on moving utils class there as it becomes repeated pattern, please note there are other tests in TS already that do already same thing). now @gtroitsk need to make changes when he has assigned ticket |
gtroitsk
force-pushed
the
migrate-hardcoded-images
branch
from
659cf7f to
032f852
Compare
|
run tests |
|
@gtroitsk 9 commits for this PR is bit excessive, please squash them |
| @@ -276,6 +281,7 @@ | |||
| <infinispan.image>quay.io/infinispan/server:14.0</infinispan.image> | |||
| <infinispan.expected-log>Infinispan Server.*started in</infinispan.expected-log> | |||
| <spring.cloud.server.image>quay.io/quarkusqeteam/spring-cloud-config-server:3.0</spring.cloud.server.image> | |||
| <keycloak.image>quay.io/keycloak/keycloak:22.0.5</keycloak.image> | |||
There was a problem hiding this comment.
I'm afraid you should wait for #1581 to get in and then rebase, not sure whether 22.0.5 is going to be needed.
...o/quarkus/ts/messaging/kafka/reactive/streams/DevModeRedPandaDevServiceUserExperienceIT.java
Show resolved
Hide resolved
gtroitsk
force-pushed
the
migrate-hardcoded-images
branch
from
ad4eb38 to
8cb13a5
Compare
|
run tests |
|
I think OC failures are unrelated |
michalvavrik
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please select the relevant options.
run testsphrase in comment)Checklist: