🎁 Support for UBI 8 and 9 #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardil
force-pushed
the
feature/multiple-ubi-releases-simple
branch
from
1a26c39
to
aef3dc9
Compare
cardil
force-pushed
the
feature/multiple-ubi-releases-simple
branch
from
aef3dc9
to
8283de2
Compare
cescoffier
requested changes
Apr 20, 2023
cescoffier
reviewed
Apr 20, 2023
|
Looks great! Thanks! |
Although, something isn't right with the build matrix. It should be 6 jobs x 2 UBIs = 12 GH jobs, but we get only 2. |
|
Hum... yes, something weird about the matrix. |
cardil
force-pushed
the
feature/multiple-ubi-releases-simple
branch
from
b32c35d
to
c446634
Compare
|
See the jobs for latest commit. It looks well: https://github.com/cardil/quarkus-images/actions/runs/4755388344 |
cescoffier
requested changes
Apr 21, 2023
|
|
||
| jobs: | ||
|
|
||
| build-images: | ||
| name: Build images | ||
| name: Build and Push images |
There was a problem hiding this comment.
It should not push by default.
| - name: Build ${{ matrix.name }} | ||
| run: mvn install --projects ${{ matrix.modules }} --also-make -DskipTests ${{ matrix.args }} | ||
|
|
||
| - name: Login to GitHub Container Registry |
There was a problem hiding this comment.
There is a workflow for push.
With this, it would push PR and main builds. We want push to be explicit.
|
@cardil any chance to get back to this :) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227