Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Management interface - TLS detection apparently doesn't check TLS registry config #44643

Closed
gsmet opened this issue Nov 22, 2024 · 3 comments · Fixed by #44648
Closed

Management interface - TLS detection apparently doesn't check TLS registry config #44643

gsmet opened this issue Nov 22, 2024 · 3 comments · Fixed by #44648
Assignees
@gsmet
Labels
area/vertx
Milestone
3.18 - main

Comments

@gsmet
Copy link
Member

gsmet commented Nov 22, 2024

I don't think NonApplicationRootPathBuildItem#isTLsConfigured() has been updated since the TLS registry was introduced.

This code probably needs some updating.

/cc @cescoffier
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 22, 2024

/cc @radcortez (config)

@cescoffier
Copy link
Member

Yes, I forgot this direct usage of the Configuration API.

@cescoffier cescoffier self-assigned this Nov 22, 2024
@gsmet
Copy link
Member Author

gsmet commented Nov 22, 2024

FWIW, I have a small patch for it in my branch, together with some doc improvements, given I was working in this area.

@gsmet gsmet mentioned this issue Nov 22, 2024
Merged
@gsmet gsmet self-assigned this Nov 22, 2024
@cescoffier cescoffier removed their assignment Nov 25, 2024
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsmet gsmet

Labels
area/vertx
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging a pull request may close this issue.

Assorted fixes for management interface gsmet/quarkus
3 participants
@cescoffier @gsmet @radcortez