-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wg template output #2154
Update wg template output #2154
Conversation
🙈 The PR is closed and the preview is expired. |
This is breaking the sync. |
I honestly don't know how this is fixing the issue and for sure it's not working anymore, as the new data is in a new file. |
hey @cescoffier the sync was already broken and this was an attempt to fix it. There's a follow up opened here: #2155 |
Which sync was broken? The working group one? It worked this weekend (at least Friday night). |
the sync of localized sites... |
What does it need? The WG sync is very simple, it just runs a script updating a file under _data (and push the change to git) |
I don't know what that line is doing:
But I guess it's where the issue needs to be fixed - not by breaking the working group sync process. |
ooook ... let me try to summarize it. see the sync of a localized site e.g. this one: https://github.com/quarkusio/ja.quarkus.io/actions/runs/11649704974/job/32437525219 the problem is in the with the changes merged in this PR https://github.com/quarkusio/quarkusio.github.io/pull/2041/files |
now see this PR: #2155 |
It was merged with my review, I just did not formally add the approval. And, apparently, was wrong. Sorry. Do I understand correctly that #2155 fixed things? |
Seems like the issue in in https://github.com/doc-l10n-kit/quarkus-l10n-utils/blob/main/lib/quarkus_l10n_utils/po_manager.py#L146. But it's calling a perl script. |
I fear it's this: https://github.com/mquinson/po4a/blob/326600634c81a49b41fe5e4e1bfaae2847e0963d/po4a-updatepo#L16 (My Perl is a bit rusty) |
Localized sites are failing the sync, e.g. https://github.com/quarkusio/ja.quarkus.io/actions/runs/11649704974/job/32437525219
This was originally fixed here #2098
But looks like the wg sync action was executed (cedef7a) that added back the file without the
.template