Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wg template output #2154

Merged

Conversation

marko-bekhta
Copy link
Contributor

Localized sites are failing the sync, e.g. https://github.com/quarkusio/ja.quarkus.io/actions/runs/11649704974/job/32437525219

This was originally fixed here #2098

But looks like the wg sync action was executed (cedef7a) that added back the file without the .template

Copy link

github-actions bot commented Nov 4, 2024

🙈 The PR is closed and the preview is expired.

@yrodiere yrodiere merged commit dc6db14 into quarkusio:main Nov 4, 2024
1 check passed
@cescoffier
Copy link
Member

This is breaking the sync.
Why this was merged without review?

@cescoffier
Copy link
Member

I honestly don't know how this is fixing the issue and for sure it's not working anymore, as the new data is in a new file.

@marko-bekhta
Copy link
Contributor Author

hey @cescoffier the sync was already broken and this was an attempt to fix it. There's a follow up opened here: #2155
sorry for the inconvenience 🙈

@cescoffier
Copy link
Member

Which sync was broken? The working group one? It worked this weekend (at least Friday night).

@marko-bekhta
Copy link
Contributor Author

the sync of localized sites...

@cescoffier
Copy link
Member

cescoffier commented Nov 4, 2024

What does it need? The WG sync is very simple, it just runs a script updating a file under _data (and push the change to git)

@cescoffier
Copy link
Member

I don't know what that line is doing:

subprocess.CalledProcessError: Command 'PERLLIB=vendor/po4a/lib vendor/po4a/po4a-updatepo --msgmerge-opt --no-fuzzy-matching --master-charset UTF-8 -f yaml --master upstream/working-groups/templates/wg.yaml --po l10n/po/ja_JP/working-groups/templates/wg.yaml.po' returned non-zero exit status 255.

But I guess it's where the issue needs to be fixed - not by breaking the working group sync process.

@marko-bekhta
Copy link
Contributor Author

ooook ... let me try to summarize it.

see the sync of a localized site e.g. this one: https://github.com/quarkusio/ja.quarkus.io/actions/runs/11649704974/job/32437525219

the problem is in the templates/wg.yaml. Which was already renamed in the past (in this PR #2098) to a wg.yml.template.

with the changes merged in this PR https://github.com/quarkusio/quarkusio.github.io/pull/2041/files
the templates/wg.yaml was added back for some reason (while it should've not).

@marko-bekhta
Copy link
Contributor Author

now see this PR: #2155
which I opened right away after realizing that the update to the GH action was wrong ...

@yrodiere
Copy link
Member

yrodiere commented Nov 4, 2024

Why this was merged without review?

It was merged with my review, I just did not formally add the approval. And, apparently, was wrong. Sorry.

Do I understand correctly that #2155 fixed things?

@cescoffier
Copy link
Member

cescoffier commented Nov 4, 2024

I approved and merged #2155 - thanks!

@yrodiere it reverts the WG sync change that broke it. But it does not fix the localized web site issue.

@cescoffier
Copy link
Member

@cescoffier
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants